LocalizedUniqueSlugField refactored

This commit is contained in:
seroy
2017-03-18 22:58:11 +03:00
parent 3951266747
commit 03df76d6d7
4 changed files with 97 additions and 73 deletions

View File

@@ -1,38 +1,17 @@
from django.db import transaction
from django.conf import settings
from django.db.utils import IntegrityError
from django.core.checks import Warning
class AtomicSlugRetryMixin:
"""Makes :see:LocalizedUniqueSlugField work by retrying upon
violation of the UNIQUE constraint."""
"""A Mixin keeped for backwards compatibility"""
def save(self, *args, **kwargs):
"""Saves this model instance to the database."""
max_retries = getattr(
settings,
'LOCALIZED_FIELDS_MAX_RETRIES',
100
@classmethod
def check(cls, **kwargs):
errors = super().check(**kwargs)
errors.append(
Warning(
'localized_fields.AtomicSlugRetryMixin is deprecated',
hint='There is no need to use '
'localized_fields.AtomicSlugRetryMixin',
obj=cls
)
)
if not hasattr(self, 'retries'):
self.retries = 0
with transaction.atomic():
try:
return super().save(*args, **kwargs)
except IntegrityError as ex:
# this is as retarded as it looks, there's no
# way we can put the retry logic inside the slug
# field class... we can also not only catch exceptions
# that apply to slug fields... so yea.. this is as
# retarded as it gets... i am sorry :(
if 'slug' not in str(ex):
raise ex
if self.retries >= max_retries:
raise ex
self.retries += 1
return self.save()
return errors