Compare commits

...

4 Commits

Author SHA1 Message Date
jar3b
55ef377926 fix: update locks; bump: 0.1.10 2021-03-12 20:01:39 +03:00
jar3b
d75e8a9725 feat: update go.mod; bump: use go 1.16 2021-03-12 19:39:40 +03:00
jar3b
7096388647 feat: fix Done lock; bump: v0.1.9 2020-11-19 16:05:45 +03:00
jar3b
b2c16b7750 feat: add back Done() to CloseHandler; bump: v0.1.8 2020-11-19 14:10:30 +03:00
5 changed files with 44 additions and 12 deletions

View File

@ -1,6 +1,6 @@
MIT License MIT License
Copyright (c) 2019 jar3b Copyright (c) 2021 jar3b
Permission is hereby granted, free of charge, to any person obtaining a copy Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal of this software and associated documentation files (the "Software"), to deal

View File

@ -1,13 +1,23 @@
package grawt package grawt
import (
"sync"
)
type CloseHandler struct { type CloseHandler struct {
waiter *Waiter waiter *Waiter
Quit chan struct{} Quit chan struct{}
active bool active bool
autoDone bool autoDone bool
wgDone bool
handlerFunc *func() handlerFunc *func()
mu *sync.Mutex
} }
func (ch *CloseHandler) Halt(err error) { func (ch *CloseHandler) Halt(err error) {
ch.waiter.Halt(err) ch.waiter.Halt(err)
} }
func (ch *CloseHandler) Done() {
ch.waiter.terminateHandler(ch, true)
}

4
go.mod
View File

@ -1,5 +1,5 @@
module github.com/jar3b/grawt module github.com/jar3b/grawt
go 1.15 go 1.16
require github.com/sirupsen/logrus v1.7.0 require github.com/sirupsen/logrus v1.8.1

4
go.sum
View File

@ -2,8 +2,8 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/sirupsen/logrus v1.7.0 h1:ShrD1U9pZB12TX0cVy0DtePoCH97K8EtX+mg7ZARUtM= github.com/sirupsen/logrus v1.8.1 h1:dJKuHgqk1NNQlqoA6BTlM1Wf9DOH3NBjQyu0h9+AZZE=
github.com/sirupsen/logrus v1.7.0/go.mod h1:yWOB1SBYBC5VeMP7gHvWumXLIWorT60ONWic61uBYv0= github.com/sirupsen/logrus v1.8.1/go.mod h1:yWOB1SBYBC5VeMP7gHvWumXLIWorT60ONWic61uBYv0=
github.com/stretchr/testify v1.2.2 h1:bSDNvY7ZPG5RlJ8otE/7V6gMiyenm9RtJ7IUVIAoJ1w= github.com/stretchr/testify v1.2.2 h1:bSDNvY7ZPG5RlJ8otE/7V6gMiyenm9RtJ7IUVIAoJ1w=
github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs= github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
golang.org/x/sys v0.0.0-20191026070338-33540a1f6037 h1:YyJpGZS1sBuBCzLAR1VEpK193GlqGZbnPFnPV/5Rsb4= golang.org/x/sys v0.0.0-20191026070338-33540a1f6037 h1:YyJpGZS1sBuBCzLAR1VEpK193GlqGZbnPFnPV/5Rsb4=

View File

@ -13,7 +13,20 @@ type Waiter struct {
blockingMode bool blockingMode bool
waitGroup sync.WaitGroup waitGroup sync.WaitGroup
closeHandlers []*CloseHandler closeHandlers []*CloseHandler
isHalting bool haltingFlag bool
haltingMutex sync.RWMutex
}
func (w *Waiter) isHalting() bool {
w.haltingMutex.RLock()
defer w.haltingMutex.RUnlock()
return w.haltingFlag
}
func (w *Waiter) setHalting(value bool) {
w.haltingMutex.Lock()
defer w.haltingMutex.Unlock()
w.haltingFlag = value
} }
func (w *Waiter) addHandler(f *func(), autoDone bool) *CloseHandler { func (w *Waiter) addHandler(f *func(), autoDone bool) *CloseHandler {
@ -22,7 +35,9 @@ func (w *Waiter) addHandler(f *func(), autoDone bool) *CloseHandler {
Quit: make(chan struct{}, 1), Quit: make(chan struct{}, 1),
active: true, active: true,
autoDone: autoDone, autoDone: autoDone,
wgDone: false,
handlerFunc: f, handlerFunc: f,
mu: &sync.Mutex{},
} }
w.Lock() w.Lock()
@ -34,18 +49,23 @@ func (w *Waiter) addHandler(f *func(), autoDone bool) *CloseHandler {
} }
func (w *Waiter) terminateHandler(h *CloseHandler, forceWaitGroupDone bool) { func (w *Waiter) terminateHandler(h *CloseHandler, forceWaitGroupDone bool) {
h.mu.Lock()
defer h.mu.Unlock()
if !h.active { if !h.active {
if !h.wgDone {
w.waitGroup.Done()
}
return return
} }
if h.handlerFunc != nil && *h.handlerFunc != nil { if h.handlerFunc != nil && *h.handlerFunc != nil {
(*h.handlerFunc)() (*h.handlerFunc)()
} }
if h.active {
close(h.Quit) close(h.Quit)
}
if h.autoDone || forceWaitGroupDone { if h.autoDone || forceWaitGroupDone {
w.waitGroup.Done() w.waitGroup.Done()
h.wgDone = true
} }
h.active = false h.active = false
@ -56,10 +76,10 @@ func (w *Waiter) AddCloseHandler(f func(), waitForChannel bool) *CloseHandler {
} }
func (w *Waiter) Halt(err error) { func (w *Waiter) Halt(err error) {
if w.isHalting { if w.isHalting() {
return return
} }
w.isHalting = true w.setHalting(true)
w.RLock() w.RLock()
for _, h := range w.closeHandlers { for _, h := range w.closeHandlers {
@ -80,13 +100,14 @@ func (w *Waiter) Halt(err error) {
} }
} }
w.isHalting = false w.setHalting(false)
} }
func (w *Waiter) Wait() { func (w *Waiter) Wait() {
w.blockingMode = true w.blockingMode = true
log.Info("Waiting...") log.Info("Waiting...")
w.waitGroup.Wait() w.waitGroup.Wait()
log.Info("Terminated")
} }
func (w *Waiter) onSignal(sig os.Signal) { func (w *Waiter) onSignal(sig os.Signal) {
@ -101,6 +122,7 @@ func NewWaiter() *Waiter {
sync.WaitGroup{}, sync.WaitGroup{},
make([]*CloseHandler, 0), make([]*CloseHandler, 0),
false, false,
sync.RWMutex{},
} }
sigs := make(chan os.Signal, 1) sigs := make(chan os.Signal, 1)
signal.Notify(sigs, syscall.SIGINT, syscall.SIGTERM) signal.Notify(sigs, syscall.SIGINT, syscall.SIGTERM)