pub/mongoengine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes multiple assignment issue preventing saves

Browse Source 
Thanks to @wpjunior for the ticket and testcase
Also fixed bug in BaseList
fixes #195
This commit is contained in:
Ross Lawley
2011-06-15 08:55:31 +01:00
parent cb1dfdfac6
commit 0338ac17b1
2 changed files with 40 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mongoengine/base.py
View File

@@ -784,9 +784,9 @@ class BaseDocument(object):
for field_name in self._fields:
key = '%s.' % field_name
field = getattr(self, field_name, None)
if isinstance(field, EmbeddedDocument): # Grab all embedded fields that have been changed
if isinstance(field, EmbeddedDocument) and field_name not in _changed_fields: # Grab all embedded fields that have been changed
_changed_fields += ["%s%s" % (key, k) for k in field._get_changed_fields(key) if k]
elif isinstance(field, (list, tuple)): # Loop list fields as they contain documents
elif isinstance(field, (list, tuple)) and field_name not in _changed_fields: # Loop list fields as they contain documents
for index, value in enumerate(field):
if not hasattr(value, '_get_changed_fields'):
continue
@@ -858,7 +858,7 @@ class BaseList(list):
def __setitem__(self, *args, **kwargs):
if hasattr(self, 'instance') and hasattr(self, 'name'):
self.instance._mark_as_changed(self.name)
super(BaseDict, self).__setitem__(*args, **kwargs)
super(BaseList, self).__setitem__(*args, **kwargs)
def __delitem__(self, *args, **kwargs):
self.instance._mark_as_changed(self.name)