From 0578cdb62ef762454941e872ca026ada5a01e5f9 Mon Sep 17 00:00:00 2001 From: Stefan Wojcik Date: Tue, 25 Jun 2019 11:41:27 +0200 Subject: [PATCH] Cleaner loop using itertools.count() --- mongoengine/base/metaclasses.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mongoengine/base/metaclasses.py b/mongoengine/base/metaclasses.py index 44b74509..c3ced5bb 100644 --- a/mongoengine/base/metaclasses.py +++ b/mongoengine/base/metaclasses.py @@ -1,3 +1,4 @@ +import itertools import warnings import six @@ -440,7 +441,7 @@ class TopLevelDocumentMetaclass(DocumentMetaclass): return id_name, id_db_name id_basename, id_db_basename, i = ('auto_id', '_auto_id', 0) - while True: + for i in itertools.count(): id_name = '{0}_{1}'.format(id_basename, i) id_db_name = '{0}_{1}'.format(id_db_basename, i) if ( @@ -448,8 +449,6 @@ class TopLevelDocumentMetaclass(DocumentMetaclass): id_db_name not in existing_db_fields ): return id_name, id_db_name - else: - i += 1 class MetaDict(dict):