From 0949df014b7f686f7e2b705fdcc6a556dd11bf51 Mon Sep 17 00:00:00 2001 From: rma4ok Date: Wed, 29 Apr 2015 01:14:48 -0400 Subject: [PATCH] [fix] SortedListField: update whole list if order is changed --- mongoengine/base/document.py | 7 +++++++ tests/fields/fields.py | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/mongoengine/base/document.py b/mongoengine/base/document.py index d31d75ba..3eba16ca 100644 --- a/mongoengine/base/document.py +++ b/mongoengine/base/document.py @@ -547,6 +547,7 @@ class BaseDocument(object): EmbeddedDocument = _import_class("EmbeddedDocument") DynamicEmbeddedDocument = _import_class("DynamicEmbeddedDocument") ReferenceField = _import_class("ReferenceField") + SortedListField = _import_class("SortedListField") changed_fields = [] changed_fields += getattr(self, '_changed_fields', []) @@ -577,6 +578,12 @@ class BaseDocument(object): if (hasattr(field, 'field') and isinstance(field.field, ReferenceField)): continue + elif (isinstance(field, SortedListField) and field._ordering): + # if ordering is affected whole list is changed + if any(map(lambda d: field._ordering in d._changed_fields, data)): + changed_fields.append(db_field_name) + continue + self._nestable_types_changed_fields( changed_fields, key, data, inspected) return changed_fields diff --git a/tests/fields/fields.py b/tests/fields/fields.py index c2967856..7a99bd78 100644 --- a/tests/fields/fields.py +++ b/tests/fields/fields.py @@ -916,6 +916,13 @@ class FieldTest(unittest.TestCase): self.assertEqual(post.comments[0].content, comment2.content) self.assertEqual(post.comments[1].content, comment1.content) + post.comments[0].order = 2 + post.save() + post.reload() + + self.assertEqual(post.comments[0].content, comment1.content) + self.assertEqual(post.comments[1].content, comment2.content) + BlogPost.drop_collection() def test_reverse_list_sorting(self):