From 53598781b843980c1caa6ee8c05327e0c38df2dd Mon Sep 17 00:00:00 2001 From: Ross Lawley Date: Tue, 11 Oct 2011 12:44:41 +0200 Subject: [PATCH 1/2] Facepalm - mutable default argument in method.. --- mongoengine/base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mongoengine/base.py b/mongoengine/base.py index 0cf57ec5..f70d0949 100644 --- a/mongoengine/base.py +++ b/mongoengine/base.py @@ -841,7 +841,7 @@ class BaseDocument(object): if hasattr(self, '_changed_fields') and key not in self._changed_fields: self._changed_fields.append(key) - def _get_changed_fields(self, key='', inspected=[]): + def _get_changed_fields(self, key='', inspected=None): """Returns a list of all fields that have explicitly been changed. """ from mongoengine import EmbeddedDocument, DynamicEmbeddedDocument From c4b0002ddb4bd6f287a488f541e38401fd8c6401 Mon Sep 17 00:00:00 2001 From: Ross Lawley Date: Tue, 11 Oct 2011 14:59:58 +0200 Subject: [PATCH 2/2] Fixed typo --- mongoengine/base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mongoengine/base.py b/mongoengine/base.py index f70d0949..a42ec449 100644 --- a/mongoengine/base.py +++ b/mongoengine/base.py @@ -654,7 +654,7 @@ class BaseDocument(object): for key, value in values.items(): setattr(self, key, value) - # Set any get_fieldname_display methodsF + # Set any get_fieldname_display methods self.__set_field_display() # Flag initialised self._initialised = True