pub/mongoengine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Deprecated get_or_create (MongoEngine/mongoengine#35)

Browse Source
This commit is contained in:
Ross Lawley 2012-11-21 16:53:06 +00:00
parent dfdc0d92c3
commit 28ef54986d
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/changelog.rst
View File

@ -4,6 +4,7 @@ Changelog
Changes in 0.8 Changes in 0.8
============== ==============
- Deprecated `get_or_create` (MongoEngine/mongoengine#35)
- Updated inheritable objects created by upsert now contain _cls (MongoEngine/mongoengine#118) - Updated inheritable objects created by upsert now contain _cls (MongoEngine/mongoengine#118)
- Added support for creating documents with embedded documents in a single operation (MongoEngine/mongoengine#6) - Added support for creating documents with embedded documents in a single operation (MongoEngine/mongoengine#6)
- Added to_json and from_json to Document (MongoEngine/mongoengine#1) - Added to_json and from_json to Document (MongoEngine/mongoengine#1)

10
mongoengine/queryset/queryset.py
View File

@ -232,10 +232,11 @@ class QuerySet(object):
dictionary of default values for the new document may be provided as a dictionary of default values for the new document may be provided as a
keyword argument called :attr:`defaults`. keyword argument called :attr:`defaults`.
.. warning:: This requires two separate operations and therefore a .. note:: This requires two separate operations and therefore a
race condition exists. Because there are no transactions in race condition exists. Because there are no transactions in
mongoDB other approaches should be investigated, to ensure you mongoDB other approaches should be investigated, to ensure you
don't accidently duplicate data when using this method. don't accidently duplicate data when using this method. This is
now scheduled to be removed before 1.0
:param write_options: optional extra keyword arguments used if we :param write_options: optional extra keyword arguments used if we
have to create a new document. have to create a new document.
@ -244,9 +245,14 @@ class QuerySet(object):
:param auto_save: if the object is to be saved automatically if :param auto_save: if the object is to be saved automatically if
not found. not found.
.. deprecated:: 0.8
.. versionchanged:: 0.6 - added `auto_save` .. versionchanged:: 0.6 - added `auto_save`
.. versionadded:: 0.3 .. versionadded:: 0.3
""" """
msg = ("get_or_create is scheduled to be deprecated. The approach is "
"flawed without transactions. Upserts should be preferred.")
raise DeprecationWarning(msg)
defaults = query.get('defaults', {}) defaults = query.get('defaults', {})
if 'defaults' in query: if 'defaults' in query:
del query['defaults'] del query['defaults']