pub/mongoengine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed: ListField minus index assignment does not work #1119

Browse Source 
Add code to detect '-1' as a integer.
Normalize negative index to regular list index
Added list assignment test case
This commit is contained in:
Gang Li
2015-10-12 10:34:26 -04:00
parent d4f6ef4f1b
commit 5bbfca45fa
2 changed files with 54 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
mongoengine/base/document.py
View File

@@ -606,7 +606,9 @@ class BaseDocument(object):
for p in parts:
if isinstance(d, (ObjectId, DBRef)):
break
elif isinstance(d, list) and p.isdigit():
elif isinstance(d, list) and p.lstrip('-').isdigit():
if p[0] == '-':
p = str(len(d)+int(p))
try:
d = d[int(p)]
except IndexError:
@@ -640,7 +642,9 @@ class BaseDocument(object):
parts = path.split('.')
db_field_name = parts.pop()
for p in parts:
if isinstance(d, list) and p.isdigit():
if isinstance(d, list) and p.lstrip('-').isdigit():
if p[0] == '-':
p = str(len(d)+int(p))
d = d[int(p)]
elif (hasattr(d, '__getattribute__') and
not isinstance(d, dict)):