pub/mongoengine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed unused var in _get_changed_fields (#347)

Browse Source
This commit is contained in:
Ross Lawley 2013-06-04 09:51:58 +00:00
parent 4244e7569b
commit 626a3369b5
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/changelog.rst
View File

@ -5,6 +5,7 @@ Changelog
Changes in 0.8.2 Changes in 0.8.2
================ ================
- Removed unused var in _get_changed_fields (#347)
- Added pre_save_post_validation signal (#345) - Added pre_save_post_validation signal (#345)
- DateTimeField now auto converts valid datetime isostrings into dates (#343) - DateTimeField now auto converts valid datetime isostrings into dates (#343)
- DateTimeField now uses dateutil for parsing if available (#343) - DateTimeField now uses dateutil for parsing if available (#343)

6
mongoengine/base/document.py
View File

@ -392,7 +392,7 @@ class BaseDocument(object):
if field_value: if field_value:
field_value._clear_changed_fields() field_value._clear_changed_fields()
def _get_changed_fields(self, key='', inspected=None): def _get_changed_fields(self, inspected=None):
"""Returns a list of all fields that have explicitly been changed. """Returns a list of all fields that have explicitly been changed.
""" """
EmbeddedDocument = _import_class("EmbeddedDocument") EmbeddedDocument = _import_class("EmbeddedDocument")
@ -423,7 +423,7 @@ class BaseDocument(object):
if (isinstance(field, (EmbeddedDocument, DynamicEmbeddedDocument)) if (isinstance(field, (EmbeddedDocument, DynamicEmbeddedDocument))
and db_field_name not in _changed_fields): and db_field_name not in _changed_fields):
# Find all embedded fields that have been changed # Find all embedded fields that have been changed
changed = field._get_changed_fields(key, inspected) changed = field._get_changed_fields(inspected)
_changed_fields += ["%s%s" % (key, k) for k in changed if k] _changed_fields += ["%s%s" % (key, k) for k in changed if k]
elif (isinstance(field, (list, tuple, dict)) and elif (isinstance(field, (list, tuple, dict)) and
db_field_name not in _changed_fields): db_field_name not in _changed_fields):
@ -437,7 +437,7 @@ class BaseDocument(object):
if not hasattr(value, '_get_changed_fields'): if not hasattr(value, '_get_changed_fields'):
continue continue
list_key = "%s%s." % (key, index) list_key = "%s%s." % (key, index)
changed = value._get_changed_fields(list_key, inspected) changed = value._get_changed_fields(inspected)
_changed_fields += ["%s%s" % (list_key, k) _changed_fields += ["%s%s" % (list_key, k)
for k in changed if k] for k in changed if k]
return _changed_fields return _changed_fields