Post refactor cleanups (ref: meta cleanups)

This commit is contained in:
Ross Lawley 2012-08-17 11:58:57 +01:00
parent 19da228855
commit 66279bd90f
3 changed files with 8 additions and 11 deletions

View File

@ -4,9 +4,7 @@ Changelog
Changes in 0.7.X Changes in 0.7.X
================= =================
- Embedded Documents dont care about inheritance - Embedded Documents no longer handle meta definitions
- Use weakref proxies in base lists / dicts (MongoEngine/mongoengine#74) - Use weakref proxies in base lists / dicts (MongoEngine/mongoengine#74)
- Improved queryset filtering (hmarr/mongoengine#554) - Improved queryset filtering (hmarr/mongoengine#554)
- Fixed Dynamic Documents and Embedded Documents (hmarr/mongoengine#561) - Fixed Dynamic Documents and Embedded Documents (hmarr/mongoengine#561)

View File

@ -394,7 +394,6 @@ class DynamicDocument(Document):
__metaclass__ = TopLevelDocumentMetaclass __metaclass__ = TopLevelDocumentMetaclass
_dynamic = True _dynamic = True
meta = {'abstract': True}
def __delattr__(self, *args, **kwargs): def __delattr__(self, *args, **kwargs):
"""Deletes the attribute by setting to None and allowing _delta to unset """Deletes the attribute by setting to None and allowing _delta to unset

View File

@ -2665,14 +2665,14 @@ class DocumentTest(unittest.TestCase):
complex fields. complex fields.
""" """
class BlogPost2(Document): class BlogPost(Document):
content = StringField() content = StringField()
authors = ListField(ReferenceField(self.Person, reverse_delete_rule=CASCADE)) authors = ListField(ReferenceField(self.Person, reverse_delete_rule=CASCADE))
reviewers = ListField(ReferenceField(self.Person, reverse_delete_rule=NULLIFY)) reviewers = ListField(ReferenceField(self.Person, reverse_delete_rule=NULLIFY))
self.Person.drop_collection() self.Person.drop_collection()
BlogPost2.drop_collection() BlogPost.drop_collection()
author = self.Person(name='Test User') author = self.Person(name='Test User')
author.save() author.save()
@ -2680,19 +2680,19 @@ class DocumentTest(unittest.TestCase):
reviewer = self.Person(name='Re Viewer') reviewer = self.Person(name='Re Viewer')
reviewer.save() reviewer.save()
post = BlogPost2(content='Watched some TV') post = BlogPost(content='Watched some TV')
post.authors = [author] post.authors = [author]
post.reviewers = [reviewer] post.reviewers = [reviewer]
post.save() post.save()
# Deleting the reviewer should have no effect on the BlogPost2 # Deleting the reviewer should have no effect on the BlogPost
reviewer.delete() reviewer.delete()
self.assertEqual(len(BlogPost2.objects), 1) self.assertEqual(len(BlogPost.objects), 1)
self.assertEqual(BlogPost2.objects.get().reviewers, []) self.assertEqual(BlogPost.objects.get().reviewers, [])
# Delete the Person, which should lead to deletion of the BlogPost, too # Delete the Person, which should lead to deletion of the BlogPost, too
author.delete() author.delete()
self.assertEqual(len(BlogPost2.objects), 0) self.assertEqual(len(BlogPost.objects), 0)
def test_two_way_reverse_delete_rule(self): def test_two_way_reverse_delete_rule(self):
"""Ensure that Bi-Directional relationships work with """Ensure that Bi-Directional relationships work with