fix the exception message when validating unicode URLs

This commit is contained in:
Stefan Wojcik 2017-02-22 12:57:00 -05:00
parent 3fe8031cf3
commit 6a59e4658e
2 changed files with 21 additions and 2 deletions

View File

@ -139,12 +139,12 @@ class URLField(StringField):
# Check first if the scheme is valid # Check first if the scheme is valid
scheme = value.split('://')[0].lower() scheme = value.split('://')[0].lower()
if scheme not in self.schemes: if scheme not in self.schemes:
self.error('Invalid scheme {} in URL: {}'.format(scheme, value)) self.error(u'Invalid scheme {} in URL: {}'.format(scheme, value))
return return
# Then check full URL # Then check full URL
if not self.url_regex.match(value): if not self.url_regex.match(value):
self.error('Invalid URL: {}'.format(value)) self.error(u'Invalid URL: {}'.format(value))
return return

View File

@ -346,6 +346,25 @@ class FieldTest(MongoDBTestCase):
class Link(Document): class Link(Document):
url = URLField() url = URLField()
link = Link()
link.url = u'http://привет.com'
# TODO fix URL validation - this IS a valid URL
# For now we just want to make sure that the error message is correct
try:
link.validate()
self.assertTrue(False)
except ValidationError as e:
self.assertEqual(
unicode(e),
u"ValidationError (Link:None) (Invalid URL: http://\u043f\u0440\u0438\u0432\u0435\u0442.com: ['url'])"
)
def test_unicode_url_validation(self):
"""Ensure unicode URLs are validated properly."""
class Link(Document):
url = URLField()
link = Link() link = Link()
link.url = 'google' link.url = 'google'
self.assertRaises(ValidationError, link.validate) self.assertRaises(ValidationError, link.validate)