pub/mongoengine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed validation for GenericReferences

Browse Source 
Where the references haven't been dereferenced
This commit is contained in:
Ross Lawley
2013-01-22 17:56:15 +00:00
parent c44b98a7e1
commit 6d68ad735c
3 changed files with 112 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
mongoengine/fields.py
View File

@@ -865,11 +865,15 @@ class GenericReferenceField(BaseField):
return super(GenericReferenceField, self).__get__(instance, owner)
def validate(self, value):
if not isinstance(value, (Document, DBRef)):
if not isinstance(value, (Document, DBRef, dict, SON)):
self.error('GenericReferences can only contain documents')
if isinstance(value, (dict, SON)):
if '_ref' not in value or '_cls' not in value:
self.error('GenericReferences can only contain documents')
# We need the id from the saved object to create the DBRef
if isinstance(value, Document) and value.id is None:
elif isinstance(value, Document) and value.id is None:
self.error('You can only reference documents once they have been'
' saved to the database')