pub/mongoengine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove unnecessary usage of the "global" keyword

Browse Source
This commit is contained in:
Stefan Wojcik 2016-12-08 23:50:36 -05:00
parent 756d8b2ac5
commit 6eb470a821
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
mongoengine/connection.py
View File

@ -55,8 +55,6 @@ def register_connection(alias, name=None, host=None, port=None,
.. versionchanged:: 0.10.6 - added mongomock support .. versionchanged:: 0.10.6 - added mongomock support
""" """
global _connection_settings
conn_settings = { conn_settings = {
'name': name or 'test', 'name': name or 'test',
'host': host or 'localhost', 'host': host or 'localhost',
@ -116,9 +114,7 @@ def register_connection(alias, name=None, host=None, port=None,
def disconnect(alias=DEFAULT_CONNECTION_NAME): def disconnect(alias=DEFAULT_CONNECTION_NAME):
global _connections """Close the connection with a given alias."""
global _dbs
if alias in _connections: if alias in _connections:
get_connection(alias=alias).close() get_connection(alias=alias).close()
del _connections[alias] del _connections[alias]
@ -127,7 +123,7 @@ def disconnect(alias=DEFAULT_CONNECTION_NAME):
def get_connection(alias=DEFAULT_CONNECTION_NAME, reconnect=False): def get_connection(alias=DEFAULT_CONNECTION_NAME, reconnect=False):
global _connections """Return a connection with a given alias."""
# Connect to the database if not already connected # Connect to the database if not already connected
if reconnect: if reconnect:
@ -221,7 +217,6 @@ def get_connection(alias=DEFAULT_CONNECTION_NAME, reconnect=False):
def get_db(alias=DEFAULT_CONNECTION_NAME, reconnect=False): def get_db(alias=DEFAULT_CONNECTION_NAME, reconnect=False):
global _dbs
if reconnect: if reconnect:
disconnect(alias) disconnect(alias)
@ -252,7 +247,6 @@ def connect(db=None, alias=DEFAULT_CONNECTION_NAME, **kwargs):
.. versionchanged:: 0.6 - added multiple database support. .. versionchanged:: 0.6 - added multiple database support.
""" """
global _connections
if alias not in _connections: if alias not in _connections:
register_connection(alias, db, **kwargs) register_connection(alias, db, **kwargs)