pub/mongoengine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed cascading saves which weren't turned off as planned (#291)

Browse Source
This commit is contained in:
Ross Lawley
2013-06-06 21:04:54 +00:00
parent d935b5764a
commit 7451244cd2
4 changed files with 22 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
mongoengine/base/metaclasses.py
View File

@@ -97,14 +97,6 @@ class DocumentMetaclass(type):
attrs['_reverse_db_field_map'] = dict(
(v, k) for k, v in attrs['_db_field_map'].iteritems())
# Set cascade flag if not set
if 'cascade' not in attrs['_meta']:
ReferenceField = _import_class('ReferenceField')
GenericReferenceField = _import_class('GenericReferenceField')
cascade = any([isinstance(x, (ReferenceField, GenericReferenceField))
for x in doc_fields.values()])
attrs['_meta']['cascade'] = cascade
#
# Set document hierarchy
#

18
mongoengine/document.py
View File

@@ -186,8 +186,8 @@ class Document(BaseDocument):
will force an fsync on the primary server.
:param cascade: Sets the flag for cascading saves. You can set a
default by setting "cascade" in the document __meta__
:param cascade_kwargs: optional kwargs dictionary to be passed throw
to cascading saves
:param cascade_kwargs: (optional) kwargs dictionary to be passed throw
to cascading saves. Implies ``cascade=True``.
:param _refs: A list of processed references used in cascading saves
.. versionchanged:: 0.5
@@ -196,11 +196,13 @@ class Document(BaseDocument):
:class:`~bson.dbref.DBRef` objects that have changes are
saved as well.
.. versionchanged:: 0.6
Cascade saves are optional = defaults to True, if you want
Added cascading saves
.. versionchanged:: 0.8
Cascade saves are optional and default to False. If you want
fine grain control then you can turn off using document
meta['cascade'] = False Also you can pass different kwargs to
meta['cascade'] = True. Also you can pass different kwargs to
the cascade save using cascade_kwargs which overwrites the
existing kwargs with custom values
existing kwargs with custom values.
"""
signals.pre_save.send(self.__class__, document=self)
@@ -251,8 +253,10 @@ class Document(BaseDocument):
upsert=True, **write_concern)
created = is_new_object(last_error)
cascade = (self._meta.get('cascade', True)
if cascade is None else cascade)
if cascade is None:
cascade = self._meta.get('cascade', False) or cascade_kwargs is not None
if cascade:
kwargs = {
"force_insert": force_insert,