From 7f0d3638bae2eb8685e55bafedfa6a11ac1b39b9 Mon Sep 17 00:00:00 2001 From: Leo Honkanen Date: Tue, 12 Jul 2011 16:10:47 +0300 Subject: [PATCH] guard against potentially destructive updates with no update parameters --- mongoengine/queryset.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mongoengine/queryset.py b/mongoengine/queryset.py index de80a3d2..d55c5f7a 100644 --- a/mongoengine/queryset.py +++ b/mongoengine/queryset.py @@ -1268,6 +1268,9 @@ class QuerySet(object): .. versionadded:: 0.2 """ + if not update: + raise OperationError("No update parameters, would remove data") + if pymongo.version < '1.1.1': raise OperationError('update() method requires PyMongo 1.1.1+') @@ -1298,6 +1301,9 @@ class QuerySet(object): .. versionadded:: 0.2 """ + if not update: + raise OperationError("No update parameters, would remove data") + if not write_options: write_options = {} update = QuerySet._transform_update(self._document, **update)