From 996618a495ce0ccf2f0b81b0666e68c5af7fb71c Mon Sep 17 00:00:00 2001 From: Stefan Wojcik Date: Wed, 12 Jun 2019 08:27:22 +0200 Subject: [PATCH] Fix wording of an exception message in QuerySet.insert --- mongoengine/queryset/base.py | 2 +- tests/queryset/queryset.py | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/mongoengine/queryset/base.py b/mongoengine/queryset/base.py index c6244825..e17c9632 100644 --- a/mongoengine/queryset/base.py +++ b/mongoengine/queryset/base.py @@ -335,7 +335,7 @@ class BaseQuerySet(object): % str(self._document)) raise OperationError(msg) if doc.pk and not doc._created: - msg = 'Some documents have ObjectIds use doc.update() instead' + msg = 'Some documents have ObjectIds, use doc.update() instead' raise OperationError(msg) signal_kwargs = signal_kwargs or {} diff --git a/tests/queryset/queryset.py b/tests/queryset/queryset.py index 04cfb061..1f09ca59 100644 --- a/tests/queryset/queryset.py +++ b/tests/queryset/queryset.py @@ -898,13 +898,19 @@ class QuerySetTest(unittest.TestCase): with self.assertRaises(OperationError) as cm: blog = Blog.objects.first() Blog.objects.insert(blog) - self.assertEqual(str(cm.exception), 'Some documents have ObjectIds use doc.update() instead') + self.assertEqual( + str(cm.exception), + 'Some documents have ObjectIds, use doc.update() instead' + ) # test inserting a query set with self.assertRaises(OperationError) as cm: blogs_qs = Blog.objects Blog.objects.insert(blogs_qs) - self.assertEqual(str(cm.exception), 'Some documents have ObjectIds use doc.update() instead') + self.assertEqual( + str(cm.exception), + 'Some documents have ObjectIds, use doc.update() instead' + ) # insert 1 new doc new_post = Blog(title="code123", id=ObjectId())