pub/mongoengine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

No longer always upsert on save

Browse Source 
closes #407
This commit is contained in:
Ross Lawley 2012-02-29 11:39:10 +00:00
parent 5a1eaa0a98
commit a2eb876f8c
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/changelog.rst
View File

@ -5,6 +5,7 @@ Changelog
Changes in dev Changes in dev
============== ==============
- No longer always upsert on save for items with a '_id'
- Error raised if update doesn't have an operation - Error raised if update doesn't have an operation
- DeReferencing is now thread safe - DeReferencing is now thread safe
- Errors raised if trying to perform a join in a query - Errors raised if trying to perform a join in a query

6
mongoengine/document.py
View File

@ -191,10 +191,11 @@ class Document(BaseDocument):
actual_key = self._db_field_map.get(k, k) actual_key = self._db_field_map.get(k, k)
select_dict[actual_key] = doc[actual_key] select_dict[actual_key] = doc[actual_key]
upsert = self._created
if updates: if updates:
collection.update(select_dict, {"$set": updates}, upsert=True, safe=safe, **write_options) collection.update(select_dict, {"$set": updates}, upsert=upsert, safe=safe, **write_options)
if removals: if removals:
collection.update(select_dict, {"$unset": removals}, upsert=True, safe=safe, **write_options) collection.update(select_dict, {"$unset": removals}, upsert=upsert, safe=safe, **write_options)
cascade = self._meta.get('cascade', True) if cascade is None else cascade cascade = self._meta.get('cascade', True) if cascade is None else cascade
if cascade: if cascade:
@ -219,6 +220,7 @@ class Document(BaseDocument):
self[id_field] = self._fields[id_field].to_python(object_id) self[id_field] = self._fields[id_field].to_python(object_id)
self._changed_fields = [] self._changed_fields = []
self._created = False
signals.post_save.send(self.__class__, document=self, created=created) signals.post_save.send(self.__class__, document=self, created=created)
def cascade_save(self, *args, **kwargs): def cascade_save(self, *args, **kwargs):