pub/mongoengine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use a set literal in _clean_settings (#1585)

Browse Source
This commit is contained in:
Davidrjx 2017-07-13 18:07:36 +08:00 committed by Stefan Wójcik
parent a8d6e59a7a
commit a7cab51369
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS
View File

@ -243,3 +243,4 @@ that much better:
* Victor Varvaryuk * Victor Varvaryuk
* Stanislav Kaledin (https://github.com/sallyruthstruik) * Stanislav Kaledin (https://github.com/sallyruthstruik)
* Dmitry Yantsen (https://github.com/mrTable) * Dmitry Yantsen (https://github.com/mrTable)
* Renjianxin (https://github.com/Davidrjx)

11
mongoengine/connection.py
View File

@ -146,13 +146,14 @@ def get_connection(alias=DEFAULT_CONNECTION_NAME, reconnect=False):
raise MongoEngineConnectionError(msg) raise MongoEngineConnectionError(msg)
def _clean_settings(settings_dict): def _clean_settings(settings_dict):
irrelevant_fields = set([ # set literal more efficient than calling set function
'name', 'username', 'password', 'authentication_source', irrelevant_fields_set = {
'authentication_mechanism' 'name', 'username', 'password',
]) 'authentication_source', 'authentication_mechanism'
}
return { return {
k: v for k, v in settings_dict.items() k: v for k, v in settings_dict.items()
if k not in irrelevant_fields if k not in irrelevant_fields_set
} }
# Retrieve a copy of the connection settings associated with the requested # Retrieve a copy of the connection settings associated with the requested