pub/mongoengine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #936 from MRigal/fix/712-avoid-crash-looping-on-corrupted-obj-id

Browse Source 
changed ObjectIdField to_python() method to avoid crash, issue 712
This commit is contained in:
Matthieu Rigal 2015-06-14 23:31:22 +02:00
commit b124836f3a
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
mongoengine/base/fields.py
View File

@ -425,8 +425,11 @@ class ObjectIdField(BaseField):
""" """
def to_python(self, value): def to_python(self, value):
if not isinstance(value, ObjectId): try:
value = ObjectId(value) if not isinstance(value, ObjectId):
value = ObjectId(value)
except:
pass
return value return value
def to_mongo(self, value): def to_mongo(self, value):

7
tests/queryset/queryset.py
View File

@ -4693,6 +4693,13 @@ class QuerySetTest(unittest.TestCase):
self.assertEquals(Animal.objects(folded_ears=True).count(), 1) self.assertEquals(Animal.objects(folded_ears=True).count(), 1)
self.assertEquals(Animal.objects(whiskers_length=5.1).count(), 1) self.assertEquals(Animal.objects(whiskers_length=5.1).count(), 1)
def test_loop_via_invalid_id_does_not_crash(self):
class Person(Document):
name = StringField()
Person.objects.delete()
Person._get_collection().update({"name": "a"}, {"$set": {"_id": ""}}, upsert=True)
for p in Person.objects():
self.assertEqual(p.name, 'a')
if __name__ == '__main__': if __name__ == '__main__':
unittest.main() unittest.main()