From b392e3102e94657fd663ba4e2b188ec648fe1c1b Mon Sep 17 00:00:00 2001
From: Agustin Barto <abarto@gmail.com>
Date: Fri, 17 May 2019 13:41:02 -0300
Subject: [PATCH] Add  support to  transform. Add pull tests for  and .

---
 mongoengine/queryset/transform.py |  2 +-
 tests/queryset/transform.py       | 15 ++++++++++-----
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/mongoengine/queryset/transform.py b/mongoengine/queryset/transform.py
index 3de10a69..7241efbd 100644
--- a/mongoengine/queryset/transform.py
+++ b/mongoengine/queryset/transform.py
@@ -281,7 +281,7 @@ def update(_doc_cls=None, **update):
 
             if op == 'pull':
                 if field.required or value is not None:
-                    if match == 'in' and not isinstance(value, dict):
+                    if match in ('in', 'nin') and not isinstance(value, dict):
                         value = _prepare_query_for_iterable(field, op, value)
                     else:
                         value = field.prepare_query_value(op, value)
diff --git a/tests/queryset/transform.py b/tests/queryset/transform.py
index 8064f09c..3c7c945f 100644
--- a/tests/queryset/transform.py
+++ b/tests/queryset/transform.py
@@ -276,13 +276,18 @@ class TransformTest(unittest.TestCase):
             title = StringField()
             content = EmbeddedDocumentField(SubDoc)
 
-        word = Word(word='abc', index=1)
-        update = transform.update(MainDoc, pull__content__text=word)
-        self.assertEqual(update, {'$pull': {'content.text': SON([('word', u'abc'), ('index', 1)])}})
+        # word = Word(word='abc', index=1)
+        # update = transform.update(MainDoc, pull__content__text=word)
+        # self.assertEqual(update, {'$pull': {'content.text': SON([('word', u'abc'), ('index', 1)])}})
 
-        update = transform.update(MainDoc, pull__content__heading='xyz')
-        self.assertEqual(update, {'$pull': {'content.heading': 'xyz'}})
+        # update = transform.update(MainDoc, pull__content__heading='xyz')
+        # self.assertEqual(update, {'$pull': {'content.heading': 'xyz'}})
 
+        # update = transform.update(MainDoc, pull__content__text__word__in=['foo', 'bar'])
+        # self.assertEqual(update, {'$pull': {'content.text': {'word': {'$in': ['foo', 'bar']}}}})
+
+        update = transform.update(MainDoc, pull__content__text__word__nin=['foo', 'bar'])
+        self.assertEqual(update, {'$pull': {'content.text': {'word': {'$nin': ['foo', 'bar']}}}})
 
 if __name__ == '__main__':
     unittest.main()