From b661afba0158befeaa8abc95f8c7184ede5aeeac Mon Sep 17 00:00:00 2001 From: Stefan Wojcik Date: Tue, 25 Jun 2019 11:34:31 +0200 Subject: [PATCH] Use set comprehensions for existing_fields & existing_db_fields --- mongoengine/base/metaclasses.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mongoengine/base/metaclasses.py b/mongoengine/base/metaclasses.py index c5363b09..44b74509 100644 --- a/mongoengine/base/metaclasses.py +++ b/mongoengine/base/metaclasses.py @@ -431,8 +431,8 @@ class TopLevelDocumentMetaclass(DocumentMetaclass): of ('auto_id_X', '_auto_id_X') if the default name is already taken. """ id_name, id_db_name = ('id', '_id') - existing_fields = new_class._fields - existing_db_fields = (v.db_field for v in new_class._fields.values()) + existing_fields = {field_name for field_name in new_class._fields} + existing_db_fields = {v.db_field for v in new_class._fields.values()} if ( id_name not in existing_fields and id_db_name not in existing_db_fields