pub/mongoengine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make the nullification an atomic operation.

Browse Source 
This shortcut works now, since hmarr fixed the unset bug in dev.
This commit is contained in:
Vincent Driessen 2010-12-05 22:40:01 -08:00
parent ad1aa5bd3e
commit d21434dfd6
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
mongoengine/document.py
View File

@ -106,18 +106,7 @@ class Document(BaseDocument):
if rule == CASCADE:
document_cls.objects(**{field_name: self.id}).delete(safe=safe)
elif rule == NULLIFY:
# TODO: For now, this makes the nullify test pass, but it would
# be nicer to use any of these two atomic versions:
#
# document_cls.objects(**{field_name: self.id}).update(**{'unset__%s' % field_name: 1})
# or
# document_cls.objects(**{field_name: self.id}).update(**{'set__%s' % field_name: None})
#
# However, I'm getting ValidationError: 1/None is not a valid ObjectId
# Anybody got a clue?
for doc in document_cls.objects(**{field_name: self.id}):
doc.reviewer = None
doc.save()
document_cls.objects(**{field_name: self.id}).update(**{'unset__%s' % field_name: 1})
id_field = self._meta['id_field']
object_id = self._fields[id_field].to_mongo(self[id_field])