From de3888a48bb05fc199479bd57ffacc234a32fadf Mon Sep 17 00:00:00 2001
From: Bastien Gerard <bast.gerard@gmail.com>
Date: Wed, 16 Dec 2020 22:45:45 +0100
Subject: [PATCH 1/2] improve github actions

---
 .github/workflows/github-actions.yml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/github-actions.yml b/.github/workflows/github-actions.yml
index 2c2166a5..2441c6c1 100644
--- a/.github/workflows/github-actions.yml
+++ b/.github/workflows/github-actions.yml
@@ -24,6 +24,8 @@ env:
 
 jobs:
   linting:
+    # Run pre-commit (https://pre-commit.com/)
+    # which runs pre-configured linter & autoformatter
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
@@ -108,7 +110,8 @@ jobs:
 
   build-n-publish-dummy:
     runs-on: ubuntu-latest
-    needs: [linting, test]
+    needs: [linting, test, build_doc_dryrun]
+    if: github.event_name != 'pull_request'
     steps:
     - uses: actions/checkout@master
     - name: Set up Python 3.7
@@ -123,7 +126,6 @@ jobs:
 #      # Although working and recommended, test-pypi has a limit
 #      # in the size of projects so it's better to avoid publishing
 #      # until there is a way to garbage collect these dummy releases
-#      if: github.event_name != 'pull_request'
 #      uses: pypa/gh-action-pypi-publish@master
 #      with:
 #        password: ${{ secrets.test_pypi_token }}
@@ -131,7 +133,7 @@ jobs:
 
   build-n-publish:
     runs-on: ubuntu-latest
-    needs: [linting, test]
+    needs: [linting, test, build_doc_dryrun, build-n-publish-dummy]
     if: github.event_name == 'create' && startsWith(github.ref, 'refs/tags/v')
     steps:
     - uses: actions/checkout@master

From 4f6a24411d25de47f015aea911a9eee1b8ab4edd Mon Sep 17 00:00:00 2001
From: Bastien Gerard <bast.gerard@gmail.com>
Date: Wed, 16 Dec 2020 22:47:43 +0100
Subject: [PATCH 2/2] remove IRC notif from CI as it doesn't seem to be still
 valuable these days

---
 .github/workflows/github-actions.yml | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/.github/workflows/github-actions.yml b/.github/workflows/github-actions.yml
index 2441c6c1..2b5d321e 100644
--- a/.github/workflows/github-actions.yml
+++ b/.github/workflows/github-actions.yml
@@ -96,18 +96,6 @@ jobs:
         cd docs
         make html-readthedocs
 
-  irc_notification:
-    runs-on: ubuntu-latest
-    needs: [linting, test]
-    steps:
-      - uses: rectalogic/notify-irc@v1
-        if: success()
-        with:
-          channel: "irc.freenode.org#mongoengine"
-          nickname: github-notifier
-          message: |
-            Build ${{ job.status }} - ${{ github.actor }} ${{ github.event_name }} ${{ github.event.ref }}
-
   build-n-publish-dummy:
     runs-on: ubuntu-latest
     needs: [linting, test, build_doc_dryrun]