pub/python-betterproto
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Properly serialize zero-value messages in a oneof group (#176)

Browse Source 
Also improve test utils to make it easier to have multiple json examples.

Co-authored-by: Christopher Chambers <chris@peanutcode.com>
This commit is contained in:
nat
2021-03-15 13:52:35 +01:00
committed by GitHub
parent 2f62189346
commit 342e6559dc
13 changed files with 98 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/inputs/oneof_enum/test_oneof_enum.py
View File

@@ -14,7 +14,9 @@ def test_which_one_of_returns_enum_with_default_value():
returns first field when it is enum and set with default value
"""
message = Test()
message.from_json(get_test_case_json_data("oneof_enum", "oneof_enum-enum-0.json"))
message.from_json(
get_test_case_json_data("oneof_enum", "oneof_enum-enum-0.json")[0]
)
assert message.move == Move(
x=0, y=0
@@ -28,7 +30,9 @@ def test_which_one_of_returns_enum_with_non_default_value():
returns first field when it is enum and set with non default value
"""
message = Test()
message.from_json(get_test_case_json_data("oneof_enum", "oneof_enum-enum-1.json"))
message.from_json(
get_test_case_json_data("oneof_enum", "oneof_enum-enum-1.json")[0]
)
assert message.move == Move(
x=0, y=0
) # Proto3 will default this as there is no null
@@ -38,7 +42,7 @@ def test_which_one_of_returns_enum_with_non_default_value():
def test_which_one_of_returns_second_field_when_set():
message = Test()
message.from_json(get_test_case_json_data("oneof_enum"))
message.from_json(get_test_case_json_data("oneof_enum")[0])
assert message.move == Move(x=2, y=3)
assert message.signal == Signal.PASS
assert betterproto.which_one_of(message, "action") == ("move", Move(x=2, y=3))